Dont log error if BSQ blocks directory does not exist in resources #5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase of REG_TEST) we do not want to log an error stacktrace but just an info message. Use `File.separator` instead of "/"
stejbac
reviewed
Dec 9, 2021
| @@ -123,9 +123,11 @@ void copyFromResources(String postFix) { | |||
| } | |||
| for (String fileName : fileNames) { | |||
| File destinationFile = new File(storageDir, fileName); | |||
| FileUtil.resourceToFile(resourceDir + "/" + fileName, destinationFile); | |||
| FileUtil.resourceToFile(resourceDir + File.separator + fileName, destinationFile); | |||
There was a problem hiding this comment.
This doesn't appear to work on Windows. It has to be "/", not "\".
There was a problem hiding this comment.
Ah really? Weird... Will revert that. Javas resource handling is really a pain.
File.separator doesn't appear to work on Windows. It has to be "/", not "\". See: bisq-network#5909 (review)
ripcurlx
pushed a commit
that referenced
this pull request
Dec 9, 2021
File.separator doesn't appear to work on Windows. It has to be "/", not "\". See: #5909 (review)
chimp1984
deleted the
avoid-logging-error-for-non-existing-resource-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the BSQ blocks directory does not exist in resources (as in case of REG_TEST)
we do not want to log an error stacktrace but just an info message.
Use
File.separatorinstead of "/"Fixes #replaceWithIssueNr, fixes #replaceWithIssueNr
Your PR description here.