Fix fat finger protection in Offer Entry screen #5914
Conversation
|
@jmacxx Can you re-produce this all the time? I tried to, but failed so far (see recording) Bildschirmaufnahme.2021-12-20.um.13.05.14.mov |
|
It is reproducible consistently, whenever the % field is by default shown at the top when the offer dialog is opened. If it is not at the top, make it so, then close the dialog and reopen to reproduce the issue. |
Now I was able to re-produce it as well. I've to check why I've added this bit in 2018 🤔 |
|
Luckily there was a test for it otherwise I wouldn't know it anymore Bildschirmaufnahme.2021-12-21.um.13.24.37.movThis change would break the behavior above, so we need to solve it somehow else. |
Normally, for currencies that have a market price feed, Bisq provents the user from entering offers that are more than 50% away from spot. It recently came to light via a mediation case that this fat finger protection in Bisq has a flaw. A certain sequence of focus operations in the enter offer screen causes fat finger protection to turn off, and then the user is no longer protected from making offers that are significantly out of the market. To reproduce the issue: Go to BUY (or SELL) BTC for an market priced asset, e.g. ETH Click Create New Offer Click the up/down arrow icon to make sure the % from market price edit box is selected at the top. Close the dialog, this saves the selected price format. Click Create New Offer Enter 0.25 BTC Tab to the next field. Click the up/down arrow icon to make sure the fixed price edit box is selected at the top. The price and deviation gets auto-populated to market price and 0% deviation. Enter a fixed price that is 10x higher than market value. Click "Next" and the fat finger protection warning DOES NOT pop up. This is because the deviation still shows 0%.
jmacxx
force-pushed
the
fix_fat_finger_protection
branch
from
a6b6b67
to
d901faa
Compare
|
Here is an alternative fix that does not break the test for #5914 (comment) |
Normally, for currencies that have a market price feed, Bisq prevents the user from entering offers that are more than 50% away from spot. It recently came to light that this fat finger protection in Bisq has a flaw.
A certain sequence of focus operations in the enter offer screen causes fat finger protection to turn off, and then the user is no longer protected from making offers that are significantly out of the market.
To reproduce the issue:
Video example:
The two lines of code removed by this PR seem to be a relic from < 2018 so its hard to locate the original intent. Regardless, it will require a good regression test to check that this fix does not affect any other path in the offer UI.