Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with edit button visibility #5969

Merged
merged 2 commits into from Jan 17, 2022
Merged

Fix issue with edit button visibility #5969

merged 2 commits into from Jan 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 16, 2022

Pull request fixes issue founded during testing:

Screenshot_2022-01-16_22-02-41

seems like using setManaged wasn't enough.

@w0000000t
Copy link
Contributor

w0000000t commented Jan 16, 2022

Just tested it on my side by editing the relevant file and rebuilding, made sure to add enough offers on both Alice's and Bob's side so scrolling was necessary, and switching between tabs... appears as fixed to me, can't reproduce the artifacts that I noticed during first test.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - It is also good practice to reset the button action if not used (see my commmit fd34053)

@ripcurlx ripcurlx added this to the v1.8.1 milestone Jan 17, 2022
@ripcurlx ripcurlx merged commit 39e3c0d into bisq-network:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants