Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API 'gettrades' method #5976

Merged
merged 35 commits into from
Feb 1, 2022
Merged

Add API 'gettrades' method #5976

merged 35 commits into from
Feb 1, 2022

Commits on Jan 16, 2022

  1. Add GetTrades proto message, + needed TradeInfo fields

    @ghubstan
    ghubstan committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    55a54f3 View commit details
    Browse the repository at this point in the history

  2. Add GrpcTradesService.getTrades service method

    @ghubstan
    ghubstan committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    e6e944b View commit details
    Browse the repository at this point in the history

  3. Add List<Trade> getTrades() to FailedTradesManager (w/out transitive … 

    …jfx dep)
    @ghubstan
    ghubstan committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    b4fa52f View commit details
    Browse the repository at this point in the history

  4. Add List<Trade> getTrades() to TradeManager (w/out transitive jfx dep)

    @ghubstan
    ghubstan committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    50bbbfe View commit details
    Browse the repository at this point in the history

  5. Add List<OpenOffer> getCanceledOpenOffers() ClosedTradableManager

    @ghubstan
    ghubstan committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    a53fee3 View commit details
    Browse the repository at this point in the history

  6. Add buyer/seller dep & status-desc fields to TradeInfoV1Builder

    @ghubstan
    ghubstan committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    5c21779 View commit details
    Browse the repository at this point in the history

  7. Add buyer/seller dep & status-desc fields to TradeInfo

    @ghubstan
    ghubstan committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    a9e7484 View commit details
    Browse the repository at this point in the history

  8. Remove commented code

    @ghubstan
    ghubstan committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    fdd94fe View commit details
    Browse the repository at this point in the history

  9. Add server impl for gettrades (open|closed), refactor getrole methods

    @ghubstan
    ghubstan committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    d98d795 View commit details
    Browse the repository at this point in the history

  10. Format gettrades CLI outout

    @ghubstan
    ghubstan committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    4c7ae49 View commit details
    Browse the repository at this point in the history

  11. Support gRPC gettrades call in CLI

    @ghubstan
    ghubstan committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    ffa31b0 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Try to display accurate status of closed trades, or "Pending" if stil… 

    …l open
    @ghubstan
    ghubstan committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    3cd1e05 View commit details
    Browse the repository at this point in the history

  2. Re-set log level to INFO in apitest cases

    @ghubstan
    ghubstan committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    a5857e2 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. Remove trailing spaces

    @ghubstan
    ghubstan committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    0ec0952 View commit details
    Browse the repository at this point in the history

  2. Fix comments

    @ghubstan
    ghubstan committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    2e7346a View commit details
    Browse the repository at this point in the history

  3. Display trade.txFee for BSQ swap trades

    @ghubstan
    ghubstan committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    b10cb11 View commit details
    Browse the repository at this point in the history

  4. Remove duplicated buyer/seller proto fields (already exist no OfferInfo)

    @ghubstan
    ghubstan committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    69e6c9c View commit details
    Browse the repository at this point in the history

  5. Fix maker/taker fee column headers & value func defs

    @ghubstan
    ghubstan committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    2a3a298 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2022

  1. Fill out gettrades-help.txt

    @ghubstan
    ghubstan committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    6e02996 View commit details
    Browse the repository at this point in the history

  2. Display tx-fee from BsqSwapProtocolModel

    @ghubstan
    ghubstan committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    fadaaf9 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2022

  1. Add payout fields to trade proto msgs, show optional trade/tx fees in… 

    … swaps
    @ghubstan
    ghubstan committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    0e020e8 View commit details
    Browse the repository at this point in the history

  2. Change var name

    @ghubstan
    ghubstan committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    3e14bd3 View commit details
    Browse the repository at this point in the history

  3. Fix displayed bsq-swap's optional trade & tx fees

    @ghubstan
    ghubstan committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    fdd91a8 View commit details
    Browse the repository at this point in the history

  4. Split BsqSwap tests into "buy" and "sell" tests

    @ghubstan
    ghubstan committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    2db20c0 View commit details
    Browse the repository at this point in the history

  5. Add BsqSwapSellBtcTradeTest

    @ghubstan
    ghubstan committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    fd0c4c2 View commit details
    Browse the repository at this point in the history

  6. Use toTradeFeeBtc, not toTradeFeeBsq

    @ghubstan
    ghubstan committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    89c4ab3 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Add Bisq license banners

    @ghubstan
    ghubstan committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    d902e77 View commit details
    Browse the repository at this point in the history

  2. Fix method name

    @ghubstan
    ghubstan committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    210d966 View commit details
    Browse the repository at this point in the history

  3. Log exception and return "Not Available" when trade role cannot be found

    @ghubstan
    ghubstan committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    4ab4c3d View commit details
    Browse the repository at this point in the history

  4. Remove unused class

    @ghubstan
    ghubstan committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    ef00a2c View commit details
    Browse the repository at this point in the history

  5. Push Trade->TradeModel mapping down from CoreApi into CoreTradesService

    @ghubstan
    ghubstan committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    4c8cec5 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Sort API gettrades's response list by trade date

    @ghubstan
    ghubstan committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    f231aac View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Revert "Sort API gettrades's response list by trade date" 

    This reverts commit f231aac.

Sorting cumulative trade history lists should be done once, in GrpcTradesService.
    @ghubstan
    ghubstan committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    ad638e3 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary casts

    @ghubstan
    ghubstan committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    8206425 View commit details
    Browse the repository at this point in the history

  3. Sort the final, cumulative trades list in gRPC GetTrades service 

    Resolves issue bisq-network#5976 (comment)
    @ghubstan
    ghubstan committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    111e39f View commit details
    Browse the repository at this point in the history