Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send meaningful io.grpc.Status.Code to gRPC clients [No. 2] #6088

Merged
merged 5 commits into from Mar 8, 2022
Merged

Send meaningful io.grpc.Status.Code to gRPC clients [No. 2] #6088

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7fb3df
Move get (cryptocurrency) offer filter to daemon
ghubstan Mar 3, 2022
d913022
Force rebuild after github action ECONNRESET
ghubstan Mar 3, 2022
784e2ae
Send meaningful io.grpc.Status.Code to gRPC clients
ghubstan Mar 5, 2022
82549b3
Fix comment
ghubstan Mar 5, 2022
df2cac3
Make codacy happy
ghubstan Mar 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion daemon/src/main/java/bisq/daemon/grpc/GrpcExceptionHandler.java
View file
Open in desktop
Expand Up @@ -137,7 +137,7 @@ else if (t instanceof bisq.core.api.exception.NotAvailableException)
return UNAVAILABLE.withDescription(description);

// If the above checks did not return an io.grpc.Status.Code, we map
// the native Java exception to an io.grpc.Status, usually defaulting to UNKNOWN.
// the native Java exception to an io.grpc.Status.
if (t instanceof IllegalArgumentException)
return INVALID_ARGUMENT.withDescription(description);
else if (t instanceof IllegalStateException)
Expand Down