Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with deleting newly created account #6166

Merged
merged 1 commit into from Apr 26, 2022
Merged

Fix issue with deleting newly created account #6166

merged 1 commit into from Apr 26, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2022

Fixes #6161

setPersistedAccountName(getAccountName()) was invoked after paymentAccountsAsObservable.add(paymentAccount);. HashSet is caching hashcodes when adding, so they didn't matched when trying to invoke paymentAccountsAsObservable.remove(paymentAccount).

More details:
https://stackoverflow.com/a/43554123

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - works for me now

@ripcurlx ripcurlx added this to the v1.9.0 milestone Apr 26, 2022
@ripcurlx ripcurlx merged commit ff6d38d into bisq-network:master Apr 26, 2022
@ghost ghost mentioned this pull request May 11, 2022
@ghost ghost mentioned this pull request Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.9.0] Newly created SEPA account can't be deleted
1 participant