Fix problems with editing account names #6167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripcurlx
suggested changes
Apr 26, 2022
There was a problem hiding this comment.
NACK - Still broken when switching back to not use a custom account name
Apr.-26 11:00:03.709 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Uncaught Exception from thread JavaFX Application Thread
Apr.-26 11:00:03.709 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableMessage= Cannot invoke "bisq.desktop.components.InputTextField.getText()" because "this.bankIdInputTextField" is null
Apr.-26 11:00:03.709 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableClass= class java.lang.NullPointerException
Apr.-26 11:00:03.709 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Stack trace:
java.lang.NullPointerException: Cannot invoke "bisq.desktop.components.InputTextField.getText()" because "this.bankIdInputTextField" is null
at bisq.desktop.components.paymentmethods.GeneralBankForm.autoFillAccountTextFields(GeneralBankForm.java:145)
at bisq.desktop.components.paymentmethods.BankForm.autoFillNameTextField(BankForm.java:401)
at bisq.desktop.components.paymentmethods.PaymentMethodForm.lambda$addAccountNameTextFieldWithAutoFillToggleButton$2(PaymentMethodForm.java:144)
ghost
requested a review
from
ripcurlx
reviewed
Apr 26, 2022
Comment on lines
141
to
150
|
|
||
|
|
||
| BankAccountPayload bankAccountPayload = null; | ||
| CashDepositAccountPayload cashDepositAccountPayload = null; | ||
| if (paymentAccountPayload instanceof BankAccountPayload) { | ||
| bankAccountPayload = (BankAccountPayload) paymentAccountPayload; | ||
| } else if (paymentAccountPayload instanceof CashDepositAccountPayload) { | ||
| cashDepositAccountPayload = (CashDepositAccountPayload) paymentAccountPayload; | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't like it so much having those checks in the abstract class for specific implementations. I think it would be better to have a getBankId, getBranchId, getBankName and getAccountNr implementation in the CashDeposit and BankAccount forms WDYT?
There was a problem hiding this comment.
Fixed in latest commit.
Code could be even more simplified when CashDepositAccountPayload extends BankAccountPayload - do you see any obstacles from doing it (in this pull request)?
There was a problem hiding this comment.
I think - let's keep it to a minimum for now. I'll test it now.
ghost
changed the title
ripcurlx
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6162