Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording & appearance of trade shutdown dialog. #6213

Merged
merged 1 commit into from
May 19, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 18, 2022

Implements suggestions here from @w0000000t .

image

I considered using an Error box which automatically includes a button to open 'bisq.log', but the error box has text saying this is a bug; whereas this case is simply a network delay. So I opted for Warning box instead. Simply waiting a bit as prompted will solve the issue in most cases, the rare ones where the condition is permanent can make it to the support channels anyway.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👍

@ripcurlx ripcurlx added this to the v1.9.2 milestone May 19, 2022
@ripcurlx ripcurlx merged commit 0ced87c into bisq-network:master May 19, 2022
@ghost ghost mentioned this pull request May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant