Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential NPE in persistence of Contract. #6955

Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 3, 2023

Fixes #6953

Handle cases where RefundAgentNodeAddress is null, (instead of causing NPE at persistence which causes trade data loss).

Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 99d45f7 into bisq-network:master Dec 20, 2023
3 checks passed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.15 milestone Dec 20, 2023
@ghost ghost mentioned this pull request Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PersistanceManager fails to persist PendingTrades
2 participants