Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Wise payment account (was TransferWise) #6964

Merged
merged 2 commits into from Dec 20, 2023
Merged

Update Wise payment account (was TransferWise) #6964

merged 2 commits into from Dec 20, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 11, 2023

Fixes #6934

  • Rename TransferWise to Wise.
  • Rename TransferWise-USD to Wise-USD.
  • Update the list of supported currencies (Wise).
  • Add HolderName, mandatory for new account creation.

HenrikJannsen
HenrikJannsen suggested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment to clearify

core/src/main/java/bisq/core/payment/payload/TransferwiseAccountPayload.java Show resolved Hide resolved
HenrikJannsen
HenrikJannsen approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

core/src/main/java/bisq/core/payment/payload/TransferwiseAccountPayload.java Show resolved Hide resolved
core/src/main/java/bisq/core/payment/payload/PaymentAccountPayload.java Show resolved Hide resolved
Update Wise (TransferWise) account.
01dc89e 
TransferWise has rebranded to Wise, rename user-facing parts.
Add HolderName (mandatory for new accounts).
@ghost ghost force-pushed the update_transferwise branch from e13c8a5 to 01dc89e Compare December 15, 2023 21:05
@ghost
Copy link
Author

ghost commented Dec 16, 2023

Code comments added, per code review.

HenrikJannsen
HenrikJannsen approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

alejandrogarcia83
alejandrogarcia83 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit d9ac334 into bisq-network:master Dec 20, 2023
3 checks passed
This was referenced Dec 24, 2023
Closed
Closed
@alvasw
Copy link
Contributor

alvasw commented Dec 31, 2023

Hi @yonson2023,
I found some time to review this PR to make sure everything is working. Unfortunately, there are some issues: the seller doesn't see the buyer's holder name, the holder name is missing on the trade details popup, and traders can't copy the holder name (all other fields have a copy button next to its field).

Seller doesn't see the buyer's holder name

  1. Create new Wise accounts with an e-mail address and a holder name on Alice's and Bob's Bisq instances.
  2. Start a trade between Alice and Bob
  3. Press the payment started button on the buyer's side
  4. The seller doesn't see the holder name of the buyer
    seller_holder_missing

Holder name is missing on both traders trade details popup

trade_details_everything_missing

Copy button missing (next to the holder name text field)

copy_button_missing

@yonson2023 Do you have time to fix these issues? Otherwise another dev can fix it.

This was referenced Dec 31, 2023
Closed
Closed
Closed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.15 milestone Dec 31, 2023
@alvasw alvasw mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.15
Development

Successfully merging this pull request may close these issues.

rename TransferWise to Wise
3 participants
@alvasw @HenrikJannsen @alejandrogarcia83