Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'reason for payment' warning instructions #6974

Merged
merged 1 commit into from Jan 25, 2024
Merged

Update 'reason for payment' warning instructions #6974

merged 1 commit into from Jan 25, 2024

Conversation

kiocosta
Copy link
Contributor

Fixes #6711

Improves the warning message by providing additional instructions on how buyers should fill the payment reason in case they're required to do so.

@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Dec 28, 2023

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

@kiocosta kiocosta mentioned this pull request Dec 28, 2023
Closed
alejandrogarcia83
alejandrogarcia83 approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.15 milestone Dec 31, 2023
@alejandrogarcia83
Copy link
Contributor

@kiocosta Thank you for opening this PR. I can't merge your PR before your commits are signed. For more information see: https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md#sign-your-commits-with-gpg

@alejandrogarcia83 alejandrogarcia83 marked this pull request as draft December 31, 2023 13:50
@kiocosta kiocosta marked this pull request as ready for review January 14, 2024 23:56
@kiocosta
Copy link
Contributor Author

hey @alejandrogarcia83 , thank you for your reply. I have signed the commit.

alejandrogarcia83
alejandrogarcia83 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 23b5424 into bisq-network:master Jan 25, 2024
3 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Jan 25, 2024

Awesome work, congrats on your first merged pull request!

@alejandrogarcia83
Copy link
Contributor

Congrats to your first merged PR in Bisq!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrogarcia83 alejandrogarcia83 alejandrogarcia83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.15
Development

Successfully merging this pull request may close these issues.

Bad SEPA instructions - payment reason field cannot be empty in my bank
2 participants
@kiocosta @alejandrogarcia83