Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unconfirmed popup to 24h after trade start. #6994

Merged
merged 1 commit into from Jan 14, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 5, 2024

Ref: #6948
@pazza83 as discussed, here is the change to the unconfirmed trade popup:

  • Instead of 4 hours now is 24 hours.
  • A button to resync is included.

Let me know if you want any wording, etc changes.

resync_popup

Existing conirmation prompt is shown before starting resync process:

resync_popup2

@pazza83
Copy link

pazza83 commented Jan 6, 2024

Thanks @jmacxx

With regards the following warning message:

294575239-2b4205f9-55c5-49a2-8c84-84d02fa9c810

Would it be possible for there to be a deposit transaction lookup prior to showing the message?

  • If the deposit transaction was still unconfirmed no error message needs to be shown
  • If the deposit transaction was confirmed on the blockchain but not showing in Bisq than an error message can be shown prompting the user to do an SPV resync

@ghost ghost force-pushed the resync_popup_change branch from f2d7cec to e082a49 Compare January 6, 2024 04:14
@ghost
Copy link
Author

ghost commented Jan 6, 2024

Would it be possible for there to be a deposit transaction lookup prior to showing the message?

@pazza83 - done.

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

utACK

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit f755efa into bisq-network:master Jan 14, 2024
3 checks passed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.15 milestone Jan 14, 2024
@ghost ghost mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants