Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1] Refactor Proto interface #7150

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

HenrikJannsen
Copy link
Collaborator

Refactor: Replace toProtoMessage().toByteArray() calls to serialize() or serializeForHash() methods.

Currenty serializeForHash just calls serialize. This will be change in later commits

… or serializeForHash() methods.

Currenty serializeForHash just calls serialize. This will be change in later commits
@HenrikJannsen HenrikJannsen changed the title Refactor Proto interface [1] Refactor Proto interface Jun 8, 2024
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.16 milestone Jun 8, 2024
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 20fbb32 into bisq-network:master Jun 8, 2024
3 checks passed
@HenrikJannsen HenrikJannsen deleted the refactor-proto branch June 13, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants