Create WalletService (1/2) #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Bisq crashes e.g. due to a crash Bisq won't be able to reconnect to the wallet because the wallet is was not properly unloaded. If it's already loaded we don't have to reload it.
In Bitcoind multiple wallets can be loaded at the same time. Each wallet gets its own RPC endpoint, and all non-wallet-related RPC methods have their own endpoint. This change creates WalletRpcConfig for the wallet endpoint. The existing RpcConfig is for non-wallet-related RPC calls, e.g., loadwallet.
Bisq will support multiple external wallets. All wallet implementations expose their functionalities using the Wallet interface. The Wallet interface should only be used within the wallet module as an abstraction.
The WalletService is the public API that other modules call. It exposes all wallet functionalities.
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WalletServiceis the public API that other modules call. It exposes all wallet functionalities. All methods of theWalletServiceare asynchronous and return aCompletableFuture.