Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle Run Task #94

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Feb 11, 2022

We cannot start the desktop app using Gradle. This change fixes this.

Changes:

  • Add JVM arguments for jfoenix
  • Load resources using ClassLoader

The jfoenix library doesn't support the module system that was
introduced in Java 9. The library accessed not exported classes.
It wasn't possible to start the desktop app using Gradle because Gradle
didn't find the resources. This change retrieves the resources by using
the classloader.
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@chimp1984 chimp1984 merged commit 4b07010 into bisq-network:main Feb 11, 2022
@alvasw alvasw deleted the fix_gradle_run_task branch February 14, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants