Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction can serialize and deserialize according to Segwit #13

Closed
ManfredKarrer opened this issue Apr 9, 2018 · 3 comments
Closed

Comments

@ManfredKarrer
Copy link
Member

I have not looked closer but that might be a critical issue we should get merged to our fork:

Transaction can serialize and deserialize according to Segwit (BIP144)
bitcoinj@b9c983e

@cbeams @ripcurlx Maybe we should try to get that into the next release as well.

@oscarguindzberg
Copy link
Collaborator

oscarguindzberg commented Feb 4, 2019

I just had a look at this issue.
This is the actual commit that is part of bitcoinj master bitcoinj@648655d
I see no need to merge this ASAP.
Segwit is a soft fork, so it is backwards compatible. Meaning any bitcoin node that does not support segwit (eg bitcoinj before 0.15 release) is still part of the network and need not be changed as long as it follows the longest chain.
Peers won't send txs serialized with the new format to peers that don't support segwit yet.

BTW, have a look at https://groups.google.com/forum/#!topic/bitcoinj/qjxgcpKak3s for the discussion about releasing bitcoinj 0.15 with segwit support.

@ManfredKarrer
Copy link
Member Author

So we can close that issue, right?

@oscarguindzberg
Copy link
Collaborator

oscarguindzberg commented Feb 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants