Wallet: clone transaction before committing #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: A transaction received from the network is added to all wallets that find it relevant. If two wallets find the same transaction relevant the same Transaction instance is added to both wallets. Spending the outputs from this transaction can cause consistiency issues, in particular if the outputs are spent in the same transaction, as shown in WalletTest.oneTxTwoWallets. There are probably more issues with having the same Transaction instance handled by two different wallets. Fix: Clone the transaction before adding it to the wallet.
chimp1984
approved these changes
Oct 21, 2021
| // two wallets depend on the same transaction. | ||
| Transaction cloneTx = tx.getParams().getDefaultSerializer().makeTransaction(tx.bitcoinSerialize()); | ||
| cloneTx.setPurpose(tx.getPurpose()); | ||
| cloneTx.setUpdateTime(tx.getUpdateTime()); |
There was a problem hiding this comment.
Are there any other properties we need to move over to the cloneTx?
Maybe avoid code duplication at line 1913 and use a method for getting the clone from the tx?
|
Closing as already integrated with 033c195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: A transaction received from the network is added to all wallets
that find it relevant. If two wallets find the same transaction relevant
the same Transaction instance is added to both wallets.
Spending the outputs from this transaction can cause consistiency
issues, in particular if the outputs are spent in the same transaction,
as shown in WalletTest.oneTxTwoWallets. There are probably more issues
with having the same Transaction instance handled by two different
wallets.
Fix: Clone the transaction before adding it to the wallet.