Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 19 #716

Closed
ghubstan opened this issue Nov 24, 2020 · 5 comments
Closed

For Cycle 19 #716

ghubstan opened this issue Nov 24, 2020 · 5 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ghubstan
Copy link
Member

ghubstan commented Nov 24, 2020

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 9067.16
  • USD requested: 6075
  • BSQ rate: 0.67 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 18 #688

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Block on tx-fee-request in core TakeOfferModel init dev 50 bisq-network/bisq#4692 merged
Add fields to grpc TradeInfo proto & wrapper dev 50 bisq-network/bisq#4696 merged
Replace TradeUtils with singleton TradeUtil dev 200 bisq-network/bisq#4697 merged
Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil dev 150 bisq-network/bisq#4699 merged
Refactor PendingTradesDataModel methods -> TradeUtil dev 150 bisq-network/bisq#4700 merged
Add getRole(tradeId) to core api dev 600 bisq-network/bisq#4701 merged
Refactor CLI output formatting code & add trade formatter dev 1100 bisq-network/bisq#4703 merged
Add 'gettrade' to api method CLI dev 500 bisq-network/bisq#4704 merged
Add boolean 'showcontract' argument to api's 'gettrade' dev 50 bisq-network/bisq#4705 merged
Stub out api methods 'keepfunds', 'withdrawfunds' dev 50 bisq-network/bisq#4709 merged
Implement api methods 'keepfunds', 'withdrawfunds' dev 1000 bisq-network/bisq#4711 merged
Test trade closing api methods 'keepfunds', 'withdrawfunds' dev 750 bisq-network/bisq#4712 merged
Stub out 'canceloffer' api method dev 50 bisq-network/bisq#4713 merged
Implement 'canceloffer' api method dev 700 bisq-network/bisq#4714 merged
Test 'canceloffer' api method dev 200 bisq-network/bisq#4716 merged
Upgrade jupiterVersion = '5.7.0' dev 25 bisq-network/bisq#4722 merged
Improve apitest cmd line console logging dev 0 bisq-network/bisq#4723 merged
Refactor api test fixture setup dev 0 bisq-network/bisq#4724 merged
Reduce apitest suite execution time dev 300 bisq-network/bisq#4725 merged
Resolve issues found in reviewed PRs 4699, 4703, 4711 dev 0 bisq-network/bisq#4731 merged
PR review dev 30 bisq-network/bisq#4702 merged
PR review dev 30 bisq-network/bisq#4706 merged
PR review dev 30 bisq-network/bisq#4715 merged
PR review dev 30 bisq-network/bisq#4787 merged
PR review dev 30 bisq-network/bisq#4829 merged

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Title Team USD Link Notes
Define new grpc bsq/btc balances protos dev --- bisq-network/bisq#4793 merged
Add proto wrappers for sending bsq, btc or all balances dev --- bisq-network/bisq#4794 merged
Define proto for api method 'getunusedbsqaddress' dev --- bisq-network/bisq#4795 merged
Define proto for api method 'sendbsq' dev --- bisq-network/bisq#4796 merged
Add proto fields to support trade fee currency choice dev --- bisq-network/bisq#4797 merged
Implement and test api method 'getunusedbsqaddress' dev --- bisq-network/bisq#4798 merged
Implement and test new getbalance(s) api methods dev --- bisq-network/bisq#4799 merged
Stub out api method 'sendbsq' in core dev --- bisq-network/bisq#4800 merged
Refactor desktop's BsqSendView 'sendbsq', share with api dev --- bisq-network/bisq#4801 merged
Support paying trade fees in bsq or btc in api dev --- bisq-network/bisq#4802 merged
Delete deprecated api wallet test, adjust api build/run doc dev --- bisq-network/bisq#4803 merged
Refactor getbalance api dev --- bisq-network/bisq#4808 merged
Add api method 'getpaymentmethods' dev --- bisq-network/bisq#4818 merged
Add api method 'getpaymentacctform' dev --- bisq-network/bisq#4819 merged
Replace existing api method 'createpaymentacct' impl dev --- bisq-network/bisq#4821 merged
Fix api's createpaymentacct validation problems dev --- bisq-network/bisq#4824 merged
Add more 'createpaymentacct' api tests dev --- bisq-network/bisq#4828 merged
Set country on MoneyGram acct in gson type adapter dev --- bisq-network/bisq#4834 merged
Update bats api test dev --- bisq-network/bisq#4836 merged
Add tx fee rate api methods, requested changes in prior PRs dev --- bisq-network/bisq#4858 merged
@MwithM MwithM added this to In Progress in Compensation Request Board Nov 26, 2020
@ghubstan ghubstan changed the title [WIP] For Cycle 19 For Cycle 19 Nov 26, 2020
@bisq-bot bisq-bot bot added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Nov 26, 2020
@MwithM MwithM moved this from In Progress to In Review in Compensation Request Board Nov 27, 2020
@MwithM MwithM added this to the Cycle 19 milestone Nov 27, 2020
@sqrrm
Copy link
Member

sqrrm commented Nov 29, 2020

I approve of this compensation request.

@MwithM MwithM moved this from In Review to Review Complete in Compensation Request Board Nov 30, 2020
@ripcurlx
Copy link
Member

As team lead I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@ghubstan
Copy link
Member Author

74b506b0b7ab2145dc68ece32cb6053e335689e1404afc19b18970af6e26bb4c

@ghubstan ghubstan added this to In progress in Ship Bisq Daemon and API Nov 30, 2020
@MwithM MwithM moved this from Review Complete to Proposal Submitted in Compensation Request Board Dec 2, 2020
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Dec 9, 2020
@bisq-bot
Copy link

bisq-bot bot commented Dec 9, 2020

Issuance by Team:

team amount BSQ amount USD
dev 9067.16 6075.00

Total Issuance: 9067.16 BSQ (equivalent to: 6075.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Dec 9, 2020

Closed as accepted.

@MwithM MwithM closed this as completed Dec 9, 2020
Compensation Request Board automation moved this from Proposal Submitted to Closed Dec 9, 2020
Ship Bisq Daemon and API automation moved this from In progress to Done Dec 9, 2020
@ghubstan ghubstan mentioned this issue Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Development

No branches or pull requests

4 participants