Define new grpc bsq/btc balances protos #4793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds proto serivces and messages to support new api implementations for serving bsq, btc or all wallet balances. - RPC GetBsqBalances will return complete BSQ balance info. - Message BsqBalanceInfo is proto returned by rpc GetBsqBalances. - RPC GetBtcBalances wil return complete BTC balance info. - Message BtcBalanceInfo is proto returned by rpc GetBtcBalances. - RPC GetBalances returns complete BTC and BSQ balance info. - Message BalancesInfo is proto returned by rpc GetBalances. RPC GetBalance remains unchnaged, still returns only the available BTC balance. It may be deprecated and removed in a future PR.
This was referenced Nov 13, 2020
This was referenced Nov 13, 2020
This was referenced Nov 21, 2020
Closed
sqrrm
reviewed
Nov 25, 2020
This was referenced Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds proto serivces and messages to support future api implementations for serving bsq, btc or all wallet balances.
RPC
GetBsqBalanceswill return complete BSQ balance info.Message
BsqBalanceInfois proto returned by rpcGetBsqBalances.RPC
GetBtcBalanceswil return complete BTC balance info.Message
BtcBalanceInfois proto returned by rpcGetBtcBalances.RPC
GetBalancesreturns complete BTC and BSQ balance info.Message
BalancesInfois proto returned by rpcGetBalances.RPC
GetBalanceremains unchnaged; it still returns only the availableBTC balance. It may be deprecated and removed in a future PR.