Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 29 #926

Closed
ghost opened this issue Oct 19, 2021 · 8 comments
Closed

For Cycle 29 #926

ghost opened this issue Oct 19, 2021 · 8 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ghost
Copy link

ghost commented Oct 19, 2021

Summary

  • BSQ requested: 2193.55
  • USD requested: 3400
  • BSQ rate: 1.55 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 28 #913

Contributions delivered

Add contributions you have delivered here as new rows in the table below. See comments below the table for guidance.

Title Team USD Link Notes
Add five Indian payment methods dev 750 bisq-network/bisq#5696 1.7.5
Display support agent's Keybase link when opening mediation / arbitration dev 100 bisq-network/bisq#5716 1.7.5
Show a warning if PC has been in sleep mode dev 50 bisq-network/bisq#5719 1.7.5
Add CelPay and Nequi payment methods dev 300 bisq-network/bisq#5721   bisq-network/bisq#5724 1.7.5
Add Tether (ERC20) dev 150 bisq-network/bisq#5735 1.7.5
Add payment methods Bizum and Pix dev 300 bisq-network/bisq#5741 1.7.5
Allow trader chat to continue after trade complete dev 150 bisq-network/bisq#5742 1.7.5
Add payment methods Monese and Satispay dev 300 bisq-network/bisq#5745 1.7.5
Fix issue of Trade Step 1 validation done too soon dev 250 bisq-network/bisq#5746 1.7.5
Allow standard mark & copy functionality for displayed text fields dev 150 bisq-network/bisq#5747 1.7.5
Fix logic of SEPA country comparison routine dev 50 bisq-network/bisq#5748 1.7.5
Add payment methods Strike and Verse dev 300 bisq-network/bisq#5752 1.7.5
Fix exception in offer entry UI dev 50 bisq-network/bisq#5753 1.7.5
Support / troubleshooting support 500 bisq-network/roles#64 (comment)

 

Other contributions

  • organizing jitsi meetings with @bisq-network/bisq-devs
  • release testing
  • maintenance/operation of compensation-bot

 

Contributions in progress

  • Developing wallet code (potentially for future Misq/Bisq)
  • Taking a look into bisq memory issues
  • PR: Fix FeeService failover issues
  • Wiz asked for a stylized fee slider which I'll work on when time permits
  • Provide a reliable lightweight monitor with notifications
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team labels Oct 19, 2021
@ripcurlx ripcurlx added this to In Review in Compensation Request Board Oct 20, 2021
@ripcurlx
Copy link
Contributor

As dev team lead I approve this compensation request for dev.

@MwithM MwithM added this to the Cycle 29 milestone Oct 20, 2021
@MwithM MwithM moved this from In Review to Review Complete in Compensation Request Board Oct 20, 2021
@ghost
Copy link
Author

ghost commented Oct 23, 2021

882905856b33e08085c61f316c13620f7e31f2db7a2c976b9b500de7d5128e2d

@MwithM MwithM moved this from Review Complete to Proposal Submitted in Compensation Request Board Oct 23, 2021
@cbeams
Copy link
Member

cbeams commented Oct 23, 2021

maintenance/operation of compensation-bot

Hey @jmacxx. I asked @MwithM to start creating actual issues around cycle deadlines so that subscribers to the compensation repository get notifications about these deadlines instead of having to diligently check in on them.

#922 is the first such example issue, and as you can see, it resulted in a bunch of false errors from the compensation-bot. Could you implement support for suppressing the bot with a #nobot hashtag in the title, or (better) a #nobot GH Issues label? Would be the equivalent of what we do with [WIP] prefixes, but made more obvious and explicit for this use case of "non-compensation request issues in the compensation repository". Thanks!

BTW, the advantage of a #nobot hashtag in the title is that any issue creator could use it, but given that the only use case we have right now for this is @MwithM creating these deadline issues, and given that he's an admin for the compensation repo, I'd think it would be better to implement a #nobot GH Issues label, as it'll be cleaner and he has permissions to apply labels at issue creation time.

@ghost
Copy link
Author

ghost commented Oct 23, 2021

@cbeams sounds good, working on it.

@leo816
Copy link

leo816 commented Oct 23, 2021

My Team Lead review is complete and I approve this request.

@pazza83
Copy link

pazza83 commented Oct 28, 2021

Hi @jmacxx just wanted to say many thanks for getting the payment methods implemented so quickly. It is much appreciated. Hopefully it will allow for more fiat payment options for traders and also open up new markets.

Many thanks 😃

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Oct 30, 2021
@ghost
Copy link

ghost commented Oct 30, 2021

Issuance by Team:

team amount BSQ amount USD
dev 1870.97 2900.00
support 322.58 500.00

Total Issuance: 2193.55 BSQ (equivalent to: 3400.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Oct 30, 2021

Closed as accepted.

@MwithM MwithM closed this as completed Oct 30, 2021
Compensation Request Board automation moved this from Proposal Submitted to Closed Oct 30, 2021
@ghost ghost mentioned this issue Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Development

No branches or pull requests

5 participants