Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Cycle 30 #949

Closed
ghost opened this issue Nov 18, 2021 · 6 comments
Closed

For Cycle 30 #949

ghost opened this issue Nov 18, 2021 · 6 comments
Assignees
@ripcurlx @leo816
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Compensation Request Board

Comments

@ghost
Copy link

ghost commented Nov 18, 2021

Summary

  • BSQ requested: 1158
  • USD requested: 2050
  • BSQ rate: 1.77 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 29 #926

Contributions delivered

Add contributions you have delivered here as new rows in the table below. See comments below the table for guidance.

Title Team USD Link Notes
Option to not repeat popup message of locked up funds from failed trade dev 50 bisq-network/bisq#5771 1.8.0
Gracefully handle null data in refresh offer message and log error dev 50 bisq-network/bisq#5788 1.8.0
Include holder name field for Monese & Satispay accounts dev 0 bisq-network/bisq#5791 1.8.0
Prevent NPE in case delayedPayoutTx is not present (failed trade) dev 50 bisq-network/bisq#5797 1.8.0
Confirm button state for BTC seller to be disabled in mediation dev 50 bisq-network/bisq#5808 1.8.0
Fix calculation & display of Locked Funds dev 250 bisq-network/bisq#5813 1.8.0
Changes required for GRIN re-listing dev 500 bisq-network/bisq#5820 1.8.0
Add payment methods Tikkie and TransferWise-USD dev 150 bisq-network/bisq#5821 1.8.0
Add payment methods ACH Transfer and Domestic Wire Transfer dev 150 bisq-network/bisq#5823 1.8.0
Fix display of missing Failed Trade tab dev 50 bisq-network/bisq#5831 1.8.0
Test and review offer fee validation PR dev 50 bisq-network/bisq#5825 1.8.0
Test and review trade fee validation PR dev 150 bisq-network/bisq#5826 1.8.0
Compensation bot update - handle the nobot label dev 50 bisq-network/growth#252
Support / troubleshooting support 500 bisq-network/roles#64 (comment)

 

Other contributions

  • organizing jitsi meetings with @bisq-network/bisq-devs
  • release testing
  • maintenance/operation of compensation-bot

 

Contributions in progress

  • Testing release 1.8.0
  • Add penalty calculation to dispute agent UI
  • Developing wallet code (potentially for future Misq/Bisq)
  • Taking a look into bisq memory issues
  • PR: Fix FeeService failover issues
  • Wiz asked for a stylized fee slider which I'll work on when time permits
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team labels Nov 18, 2021
@ripcurlx
Copy link
Contributor

As dev team lead I approve this compensation request. @jmacxx As always you undervalue your work.

@ripcurlx ripcurlx added this to Review Complete in Compensation Request Board Nov 18, 2021
@chimp1984
Copy link

@jmacxx I think your request is too low.

@ghost
Copy link
Author

ghost commented Nov 18, 2021

Thanks! I'll leave this CR as-is, but appreciate the feedback! 😜

@leo816
Copy link

leo816 commented Nov 18, 2021

My Team Lead review is complete and I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@ghost
Copy link
Author

ghost commented Nov 19, 2021

23dc8fe6fda2a4a0daa25a7857ad061d1fa7c92ba2aefa04b11275e88f0620ec

@MwithM MwithM moved this from Review Complete to Proposal Submitted in Compensation Request Board Nov 19, 2021
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Dec 2, 2021
@MwithM
Copy link
Contributor

MwithM commented Dec 2, 2021

Closed as accepted

@MwithM MwithM closed this as completed Dec 2, 2021
Compensation Request Board automation moved this from Proposal Submitted to Closed Dec 2, 2021
@ghost ghost mentioned this issue Dec 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ripcurlx ripcurlx

@leo816 leo816

Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Compensation Request Board
  
Closed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ripcurlx @MwithM @chimp1984 @leo816