Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinates of right image border #105

Open
ChristPi opened this issue Nov 9, 2018 · 2 comments
Labels
bug

Comments

@ChristPi
Copy link

@ChristPi ChristPi commented Nov 9, 2018

When labeling a 640x480 image the coordinates possible for bounding boxes are 0 to 480 in vertical direction and 0 to 641 in horizontal direction. It seems to be impossible to get exactly the coordinate 640.
When saving a label with the coordinate 641, editing the label will result in editing a replacement 2x2 box.

@NFiedler NFiedler added the bug label Nov 9, 2018
@NFiedler

This comment has been minimized.

Copy link
Member

@NFiedler NFiedler commented Nov 9, 2018

I think the problem is a result of a rounding error. We should set those values to min(0) and max(width or height -1)after drawing them into the image.

@ChristPi

This comment has been minimized.

Copy link
Author

@ChristPi ChristPi commented Nov 9, 2018

Trying to edit an old image with a coordinate of 640 will result in a similar scenario of a replacement 2x2 box. Editing a box at any other of the edges will not result in this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.