Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDF iteration count far to low to be meaningful. #3

Closed
gmaxwell opened this issue Jan 30, 2014 · 1 comment
Closed

KDF iteration count far to low to be meaningful. #3

gmaxwell opened this issue Jan 30, 2014 · 1 comment

Comments

@gmaxwell
Copy link

Picked a file at random to look at.. got crypt.h

Your KDF iteration count is far too low to meaningfully slow attacks. A typical bitcoin-qt wallet uses over 100,000 iterations of SHA512, you're using about 1000. This should really be stored in your wallet and adapted to the users system to get the highest amount you can take with acceptable performance. (Bitcoin-qt uses 100ms worth, subject to a minimum of 25,000 iterations. Reasonable minds might differ on the timings, but I think 1337 iterations is way too little, it's even less than linux distros are using for login passwords)

@mx4
Copy link
Contributor

mx4 commented Jan 30, 2014

Fair enough. Now fixed with ac70018.

@mx4 mx4 closed this as completed Jan 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants