Replace wrapLines() with Python's textwrap.wrap()

[buhtz]

Introduction

Welcome to the project, if you pick up this Issue because of the "GOOD FIRST USE" label. You will be mentored through the process if you want. First the Issue is explained. At the end you will find some guidance for first contributors. Please do not hesitate to ask questions. Your solution don't need to be perfect.

Problem

BIT has it's own function logger.py::wrapLines() but Python offer the same functionality with textwrap.wrap().

Solution

Replace that function with textwrap.wrap(). Check via git grep where it is used in the code. It is not much. Easy to replace.

Argument new_line_indicator is used in logger.py::_do_syslog(). Use textwrap.wrap(..., subsequent_indent='CONTINUE: ') instead.

Your next steps

1. If this is your first contribution in this project please introduce your self and tell us about your skills, wishes and plans.
2. Read the existing contributors documentation.
3. We can develop the next steps in the further discussion. Don't hesitate to ask.

Related code

backintime/common/logger.py

Lines 149 to 184 in 5aa0746

	def wrapLine(msg, size=950, delimiters='\t ', new_line_indicator = 'CONTINUE: '):
	"""
	Wrap line ``msg`` into multiple lines with each shorter than ``size``. Try
	to break the line on ``delimiters``. New lines will start with
	``new_line_indicator``.
	Args:
	msg (str): string that should get wrapped
	size (int): maximum length of returned strings
	delimiters (str): try to break ``msg`` on these characters
	new_line_indicator (str): start new lines with this string
	Yields:
	str: lines with max ``size`` length
	"""
	# TODO Use "textwrap.wrap" instead (https://docs.python.org/3/library/textwrap.html)
	# (which may change the output formatting and may affect unit tests then)
	# To avoid duplicated argument values in calls this function could
	# act as a wrapper-
	if len(new_line_indicator) >= size - 1:
	new_line_indicator = ''
	while msg:
	if len(msg) <= size:
	yield(msg)
	break
	else:
	line = ''
	for look in range(size-1, size//2, -1):
	if msg[look] in delimiters:
	line, msg = msg[:look+1], new_line_indicator + msg[look+1:]
	break
	if not line:
	line, msg = msg[:size], new_line_indicator + msg[size:]
	yield(line)