-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gui): Improved Exclude tab in Manage profiles dialog with SSH encrypted profiles #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhtz
commented
May 2, 2024
buhtz
added
Cosmetics
appearance, icons, themes
PR: Waiting for review
PR won't be merged until review and approval from a member of the maintenance team.
labels
May 2, 2024
buhtz
commented
May 3, 2024
aryoda
approved these changes
May 3, 2024
buhtz
commented
May 4, 2024
Merged
aryoda
approved these changes
May 6, 2024
buhtz
added
PR: Merge after creative-break
Merge after creative-break (min. 1 week)
and removed
PR: Waiting for review
PR won't be merged until review and approval from a member of the maintenance team.
labels
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Cosmetics
appearance, icons, themes
PR: Merge after creative-break
Merge after creative-break (min. 1 week)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Exclude TAB in Manage profiles improved in context of SSH encrypted mode (using encfs). As explained in #1618 some exclude patterns are not functional with EncFS so they are ignored and visually disabled.
<code>
tag in richtext mode)Wouldn't give this an extra changelog.
Close #1618