Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gui): Improved Exclude tab in Manage profiles dialog with SSH encrypted profiles #1710

Merged
merged 7 commits into from May 12, 2024

Conversation

buhtz
Copy link
Member

@buhtz buhtz commented May 2, 2024

The Exclude TAB in Manage profiles improved in context of SSH encrypted mode (using encfs). As explained in #1618 some exclude patterns are not functional with EncFS so they are ignored and visually disabled.

  • The items fore and background ColroRole now try to imitate disabled state. But they are still selectable (e.g. to delete them).
  • That items now have a tool tip to explain why they are disabled.
  • warning message on top of the exclude list:
    • improved wording
    • Examples in brackets now using monotyp font (via <code> tag in richtext mode)
  • Slightly refactoring of some code.

1618_light
1618_dark

Wouldn't give this an extra changelog.

Close #1618

qt/settingsdialog.py Outdated Show resolved Hide resolved
@buhtz buhtz added Cosmetics appearance, icons, themes PR: Waiting for review PR won't be merged until review and approval from a member of the maintenance team. labels May 2, 2024
qt/settingsdialog.py Outdated Show resolved Hide resolved
@buhtz
Copy link
Member Author

buhtz commented May 3, 2024

From maintainer to maintainer: I discovered this cool suggestion-feature.

image

@aryoda
Copy link
Contributor

aryoda commented May 3, 2024

From maintainer to maintainer: I discovered this cool suggestion-feature.

image

I can't see this button. In which context did you see it? In issue comments, PR comments...?

qt/settingsdialog.py Show resolved Hide resolved
@buhtz
Copy link
Member Author

buhtz commented May 4, 2024

gh_suggestions

qt/settingsdialog.py Outdated Show resolved Hide resolved
@buhtz buhtz mentioned this pull request May 5, 2024
@buhtz buhtz added PR: Merge after creative-break Merge after creative-break (min. 1 week) and removed PR: Waiting for review PR won't be merged until review and approval from a member of the maintenance team. labels May 6, 2024
@buhtz buhtz merged commit e83a3ec into bit-team:dev May 12, 2024
1 check passed
@buhtz buhtz deleted the fix/1618encfscolor branch May 12, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cosmetics appearance, icons, themes PR: Merge after creative-break Merge after creative-break (min. 1 week)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tooltip/explanation for color-highlighted "Exclude" entries in "SSH encrypted" mode
2 participants