Retrieve path device and filesystem via df command #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df command encapsulates mtab so we don't have to parce it ourselves. In particular, fixes a bug when paths with spaces where not handled properly.
karlicoss
force-pushed
the
fix-spaces-in-labels
branch
from
4ac55fc
to
570bb6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I finally decided to automate my backups and use backintime. I tested scheduled udev-triggered backups on a flash drive few days ago, everything worked fine. So I decided to configure backups on my external HDD today, but it didn't work, plugging in the drive didn't trigger backintime.
After a short investigation, I found out my udev file was set up to trigger on some unknown UUID, even
blkidwouldn't list it. So, I dug in source code and figured out that thetools.devicefunction returnedNonefor my drive.The reason was: its label ('karlicoss hdd') contained a space, so it was mounted to
/media/karlicos/karlicoss hdd/, however,/etc/mtabtreats spaces as separators, so he escapes paths likeAs you can see, spaces map to
\040. So, probably a good idea is, instead of manually parsing/etc/mtab, use thedfcommand from coreutils, which does all the job for us.A followup question, what is the rationale behind this UUID fallback logic? In my case, it seemed to have cached the flash drives' UUID, and silently used it instead my HDD's UUID. Maybe, we should at list show some warning/notification to user so he knows something went not as expected?