Merge pull request #12 from shochdoerfer/feature/phpstan_strict

Add phpstan/phpstan-strict-rules dependency

composer.json

@@ -21,7 +21,8 @@
     "phpstan/phpstan": "^0.12",
     "roave/security-advisories": "dev-latest",
     "infection/infection": "^0.21.0",
-    "bitexpert/captainhook-infection": "^0.1.0"
+    "bitexpert/captainhook-infection": "^0.1.0",
+    "phpstan/phpstan-strict-rules": "^0.12.9"
   },
   "autoload": {
     "psr-4": {

phpstan.neon

@@ -1,5 +1,7 @@
 parameters:
-    level: 7
+    level: max
+    fileExtensions:
+        - php
     paths:
-        - src
-
+        - src/bitExpert
+        - tests/bitExpert

src/bitExpert/CaptainHook/ValidateAuthor/ValidateAuthorAction.php

@@ -28,7 +28,7 @@ class ValidateAuthorAction implements Action
     private $runner;
 
     /**
-     * Creates new {@link \bitExpert\CaptainHook\Validate\ValidateAuthorAction}.
+     * Creates new {@link \bitExpert\CaptainHook\ValidateAuthor\ValidateAuthorAction}.
      */
     public function __construct()
     {

tests/bitExpert/CaptainHook/ValidateAuthor/ValidateAuthorActionUnitTest.php

@@ -26,23 +26,23 @@
 class ValidateAuthorActionUnitTest extends TestCase
 {
     /**
-     * @var Config|MockObject
+     * @var MockObject&Config
      */
     private $config;
     /**
-     * @var IO|MockObject
+     * @var MockObject&IO
      */
     private $io;
     /**
-     * @var Repository|MockObject
+     * @var MockObject&Repository
      */
     private $repository;
     /**
-     * @var Action|MockObject
+     * @var MockObject&Action
      */
     private $action;
     /**
-     * @var ValidateAuthorAction
+     * @var MockObject&ValidateAuthorAction
      */
     private $hook;
 
@@ -64,7 +64,7 @@ public function setUp(): void
     /**
      * @test
      */
-    public function missingConfigurationStopsExecution()
+    public function missingConfigurationStopsExecution(): void
     {
         $this->action->expects(self::once())
             ->method('getOptions')
@@ -79,7 +79,7 @@ public function missingConfigurationStopsExecution()
     /**
      * @test
      */
-    public function configuredNameRegexWillTriggerValidation()
+    public function configuredNameRegexWillTriggerValidation(): void
     {
         $this->action->expects(self::once())
             ->method('getOptions')
@@ -96,7 +96,7 @@ public function configuredNameRegexWillTriggerValidation()
     /**
      * @test
      */
-    public function nameValidationWillNotThrowExceptionIfMatches()
+    public function nameValidationWillNotThrowExceptionIfMatches(): void
     {
         $this->action->expects(self::once())
             ->method('getOptions')
@@ -113,9 +113,9 @@ public function nameValidationWillNotThrowExceptionIfMatches()
     /**
      * @test
      */
-    public function nameValidationWillThrowExceptionIfNotMatches()
+    public function nameValidationWillThrowExceptionIfNotMatches(): void
     {
-        self::expectException(RuntimeException::class);
+        $this->expectException(RuntimeException::class);
 
         $this->action->expects(self::once())
             ->method('getOptions')
@@ -132,7 +132,7 @@ public function nameValidationWillThrowExceptionIfNotMatches()
     /**
      * @test
      */
-    public function configuredEmailRegexWillTriggerValidation()
+    public function configuredEmailRegexWillTriggerValidation(): void
     {
         $this->action->expects(self::once())
             ->method('getOptions')
@@ -149,7 +149,7 @@ public function configuredEmailRegexWillTriggerValidation()
     /**
      * @test
      */
-    public function emailValidationWillNotThrowExceptionIfMatches()
+    public function emailValidationWillNotThrowExceptionIfMatches(): void
     {
         $this->action->expects(self::once())
             ->method('getOptions')
@@ -166,9 +166,9 @@ public function emailValidationWillNotThrowExceptionIfMatches()
     /**
      * @test
      */
-    public function emailValidationWillThrowExceptionIfNotMatches()
+    public function emailValidationWillThrowExceptionIfNotMatches(): void
     {
-        self::expectException(RuntimeException::class);
+        $this->expectException(RuntimeException::class);
 
         $this->action->expects(self::once())
             ->method('getOptions')