Allow Magento admin to log in as customer

bitExpert · May 12, 2022 · 8b71fb0 · 8b71fb0
1 parent 34dd010
commit 8b71fb0
Show file tree

Hide file tree

Showing 2 changed files with 76 additions and 32 deletions.
diff --git a/Controller/LoginCheck.php b/Controller/LoginCheck.php
@@ -134,6 +134,13 @@ public function execute()
             return false;
         }
 
+        // allow "Login as customer" via Magento Admin
+        $sessionData = $this->session->getData();
+        $afterLoginReferer = $sessionData['after_login_referer'] ?? '';
+        if (strpos($afterLoginReferer, 'loginascustomer') !== false) {
+            return false;
+        }
+
         $url = $this->url->getCurrentUrl();
         $urlParts = \parse_url($url);
         $path = is_array($urlParts) && isset($urlParts['path']) ? $urlParts['path'] : '';

diff --git a/Test/Unit/Controller/LoginCheckUnitTest.php b/Test/Unit/Controller/LoginCheckUnitTest.php
@@ -104,7 +104,8 @@ private function getSession()
         return $this->getMockBuilder(Session::class)
             ->disableOriginalConstructor()
             ->setMethods([
-                'setAfterLoginReferer'
+                'setAfterLoginReferer',
+                'getData'
             ])
             ->getMock();
     }
@@ -197,37 +198,6 @@ private function getRequestObject()
         return $this->createMock(RequestHttp::class);
     }
 
-    /**
-     * Run test with url equals target, so no redirecting is happening.
-     *
-     * @test
-     * @depends testConstructor
-     */
-    public function skipMatchingWhenModuleIsDisabled()
-    {
-        $moduleCheck = $this->getModuleCheck();
-        $moduleCheck->expects($this->once())
-            ->method('isModuleEnabled')
-            ->willReturn(false);
-
-        $context = $this->getContext();
-
-        $loginCheck = new LoginCheck(
-            $context,
-            $this->getCustomerSession(),
-            $this->getSession(),
-            $this->getStoreManager(),
-            $this->getScopeConfig(),
-            $this->getWhitelistRepository(),
-            $this->getStrategyManager(),
-            $moduleCheck,
-            $this->getResponseHttp(),
-            $this->getPasswordResetHelper()
-        );
-
-        $loginCheck->execute();
-    }
-
     /**
      * @return MockObject|UrlInterface
      */
@@ -262,6 +232,37 @@ private function getPasswordResetHelper()
             ->getMock();
     }
 
+    /**
+     * Run test with url equals target, so no redirecting is happening.
+     *
+     * @test
+     * @depends testConstructor
+     */
+    public function skipMatchingWhenModuleIsDisabled()
+    {
+        $moduleCheck = $this->getModuleCheck();
+        $moduleCheck->expects($this->once())
+            ->method('isModuleEnabled')
+            ->willReturn(false);
+
+        $context = $this->getContext();
+
+        $loginCheck = new LoginCheck(
+            $context,
+            $this->getCustomerSession(),
+            $this->getSession(),
+            $this->getStoreManager(),
+            $this->getScopeConfig(),
+            $this->getWhitelistRepository(),
+            $this->getStrategyManager(),
+            $moduleCheck,
+            $this->getResponseHttp(),
+            $this->getPasswordResetHelper()
+        );
+
+        $loginCheck->execute();
+    }
+
     /**
      * Run test with existing customer session, so no redirecting is happening.
      *
@@ -298,6 +299,42 @@ public function skipMatchingWhenCustomerSessionIsActive()
         $loginCheck->execute();
     }
 
+    /**
+     * Run test with a Magento Admin logging in as customer, so no redirecting is happening.
+     *
+     * @test
+     * @depends testConstructor
+     */
+    public function skipMatchingWhenCustomerLoginViaMagentoAdminHappens()
+    {
+        $moduleCheck = $this->getModuleCheck();
+        $moduleCheck->expects($this->once())
+            ->method('isModuleEnabled')
+            ->willReturn(true);
+
+        $session = $this->getSession();
+        $session->expects($this->once())
+            ->method('getData')
+            ->willReturn(['after_login_referer' => 'loginascustomer']);
+
+        $context = $this->getContext();
+
+        $loginCheck = new LoginCheck(
+            $context,
+            $this->getCustomerSession(),
+            $session,
+            $this->getStoreManager(),
+            $this->getScopeConfig(),
+            $this->getWhitelistRepository(),
+            $this->getStrategyManager(),
+            $moduleCheck,
+            $this->getResponseHttp(),
+            $this->getPasswordResetHelper()
+        );
+
+        $loginCheck->execute();
+    }
+
     /**
      * Run test with url equals target, so no redirecting is happening.
      *