Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP7.3 and Magento 2.3.3 version requirements #172

Merged
merged 1 commit into from Oct 31, 2019

Conversation

mirsch
Copy link
Contributor

@mirsch mirsch commented Oct 26, 2019

See #171

@DanielRuf
Copy link

@mirsch thanks for your PR =)

This looks good so far.
Can you revert the change of the lockfile? We will update it before we will do the next release.

@mirsch
Copy link
Contributor Author

mirsch commented Oct 26, 2019

@DanielRuf I did not commit the lockfile in first attempt but without an update it breaks travis, because composer validate will fail with The lock file is not up to date with the latest changes in composer.json, it is recommended that you run 'composer update'.
I reverted now, but have to update at least content-hash and platform reqs. to get green light from ci.

@shochdoerfer shochdoerfer merged commit e111ffa into bitExpert:master Oct 31, 2019
@shochdoerfer
Copy link
Member

@mirsch looks good to me. Thank you. Will try to get release out in the next few days.

@shochdoerfer shochdoerfer added this to the 4.0.0 milestone Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants