Omit namespace for non-namespace Factory #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thanks @jbrada for your first contribution. Will have a look soon and hopefully merge it quickly :) |
|
Looks good to me. Straight forward change. |
|
I can probably build the next release in a few days. |
|
Great :-), Keep up the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use Factory in the code for a class that does not have a namespace, phpstan will return an error.
For example:
use Zend_Db_Adapter_SqlsrvFactoryIn this case, the generated file has an empty namespace.
This pull request adds a condition that makes this case remain without a namespace.
Before:
After:
