Improve code generation for factories & proxies #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to use PHPStan's caching mechanism for generating factory & proxy classes, a simplified version of a file cache storage is added.
Unfortunately made it impossible to overload the autoloader and magically set the custom autoloaders needed for the extension to run. Thus I removed the registration.php file handled the magic. This means regardless of using the .phar archive or phpstan-src dependency, you have to manually configure the autoload.php work-a-round in the project's phpstan configuration.
To make sure that the cached files are generated in the same cache directory as the regular phpstan files, find the phpstan configuration and parse it via Nette\Neon parser. Downside: The configuration gets parsed twice but I did not notice any bigger speed difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally the fix for #6: Instead of regenerating the factory & proxy files during each run, the generated files are now cached via PHPStan's caching mechanism.
In addition to that, the whole autoloading process was refactored. Unfortunately due to changes in the phpstan codebase it was no longer possible to inject the autolading code magically by overwriting the spl_autoload_register() calls. You have to load now the autoload.php file anyways. Technically you had to do that before anyways so I would not consider this a BC break.