Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add phpstan/phpstan-strict-rules #67

Merged
merged 3 commits into from Feb 13, 2021
Merged

Add phpstan/phpstan-strict-rules #67

merged 3 commits into from Feb 13, 2021

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Feb 11, 2021 •
edited

I can carry a sack of rocks 馃椏馃椏馃椏 but this is mountain! 鉀帮笍

From #64 (comment)

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Feb 11, 2021 •
edited

Could you help me with the last (not counting tests...) Short ternary operator is not allowed ?

@szepeviktor
Copy link
Contributor Author

Actually ignoring - '~^Dynamic call to static method PHPUnit\\Framework\\~' gets us 3 :) errors.

@shochdoerfer
Copy link
Member

Will check later.

Would probably rather ignore the tests than ignoring the error.

@shochdoerfer shochdoerfer merged commit a98b622 into bitExpert:master Feb 13, 2021
@shochdoerfer
Copy link
Member

Fixed the tests and some more minor issues. Thanks.

@shochdoerfer shochdoerfer added this to the 0.7.0 milestone Feb 13, 2021
@shochdoerfer shochdoerfer mentioned this pull request Feb 13, 2021
Merged
@szepeviktor szepeviktor deleted the strict-rules branch February 13, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szepeviktor @shochdoerfer