Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

Update docs to refelect the changes of Expressive 2.x #19

Merged
merged 2 commits into from
Jun 4, 2017

Conversation

shochdoerfer
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.871% when pulling b9a4b60 on shochdoerfer:feature/extended_docs into bd141ec on bitExpert:master.

@shochdoerfer shochdoerfer added this to the 0.5.0 milestone May 26, 2017
@belgattitude
Copy link
Contributor

Looks good, but not yet fully working... Still need to figure out how to make collectors works under expressive 2.

FYI, I've moved the issue concerning registration to zendframework/zend-expressive#488.

Let's give it some more time.

@belgattitude
Copy link
Contributor

@shochdoerfer

Ok so, only the timeline is missing. Probably a problem linked to pipeline priority. If I look to your blog, I noticed:

return [
    'middleware_pipeline' => [[
        'middleware' => bitExpert\Http\Middleware\Psr7\
            Prophiler\ProphilerMiddleware::class,
        'priority' => 11000,
    ]]
];

Just question, is the middleware supposed to be registered first or last ?

Thanks,

Seb

@belgattitude
Copy link
Contributor

@shochdoerfer

forget about my previous comment, normal there's nothing in the timeline, I don't log anything ;)

So for me the P/R is ok... But would be nice to have extended documentation about how collectors works... or at least a reference to https://github.com/fabfuel/prophiler-demo/blob/develop/public/demo.php

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.871% when pulling 625c0ee on shochdoerfer:feature/extended_docs into 2554788 on bitExpert:master.

@shochdoerfer shochdoerfer merged commit 23f5dc5 into bitExpert:master Jun 4, 2017
@shochdoerfer shochdoerfer deleted the feature/extended_docs branch June 4, 2017 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants