Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for dnscrypt-proxy 2.1.0+ compatibility #558

Merged
merged 9 commits into from
Dec 30, 2021

Conversation

Dola-Shuvi
Copy link
Contributor

These commits contain changes to support dnscrypt-proxy version 2.1.0 and above. The currently used version 2.0.42 is from 26th March 2020 and quite outdated.

I attempted to automatically remove the daemonize configuration setting as it caused dnscrypt-proxy to exit with an error.
Most other changes were renaming of configuration settings as per the 2.1.0 and above spec of dnscrypt-proxy.

In the future the fallback_resolvers setting will also have to be renamed to bootstrap_resolvers but as of now there is only a deprecation warning.
Some other changes such as the new NOT_READY return code might be worth implementing in the query log tab too.

@Shanks17782
Copy link

Thanks for the information.
But I have 1 question: how to update SimpleDNS with the new configuration / how to make this configuration work with SimpleDNS?
Thank you in advance for your attention to my question

@Dola-Shuvi
Copy link
Contributor Author

Thanks for the information. But I have 1 question: how to update SimpleDNS with the new configuration / how to make this configuration work with SimpleDNS? Thank you in advance for your attention to my question

I'm not quite sure I understand your question?

If you build and run 40578629176b0ca6bddc7813597f634e5fedb7c8 then your configuration should be automatically updated to the new format.

If you want to use the 0.7.1 release then changing your configuration to the new format manually probably won't work as SimpleDnsCrypt will likely overwrite your changes. I haven't verified this situation but this is what I assume would happen

@Shanks17782
Copy link

Thanks for your answer.

Actually, I installed the EXE program "Simple DnsCrypt 0.7.1" by Christian Hermann (Windows 10) and now I would like to use it with the new version of dnscrypt-proxy 2.1.0.
What do I need to download / what program do I need to use to make this work? (I am definitely not a programming specialist).

If you build and run 4057862 then your configuration should be automatically updated to the new format>

I actually tested with "Simple DnsCrypt" a version of dnscrypt-proxy 2.1.0 that I downloaded and found that the program was no longer working properly. So I reinstalled the old version completely.

If I'm not wrong, there are some questions that might be similar to mine, especially on:
#557

@Dola-Shuvi
Copy link
Contributor Author

Thanks for your answer.

Actually, I installed the EXE program "Simple DnsCrypt 0.7.1" by Christian Hermann (Windows 10) and now I would like to use it with the new version of dnscrypt-proxy 2.1.0. What do I need to download / what program do I need to use to make this work? (I am definitely not a programming specialist).

If you build and run 4057862 then your configuration should be automatically updated to the new format>

You would need Microsoft Visual Studio 2017 or newer with the C# programming toolchain to compile the program from source. As I do not have access to Christian's signing and packaging setup to create an easy installer the best I could do is distribute unsigned versions that would have to be installed via drag&drop. I could provide these if demand is high enough.

I actually tested with "Simple DnsCrypt" a version of dnscrypt-proxy 2.1.0 that I downloaded and found that the program was no longer working properly. So I reinstalled the old version completely.

As you have experienced, the old 0.7.1 version of SimpleDnsCrypt does not work with version 2.1.0 or newer of dnscrypt-proxy. Currently you would have to either use the old version of SimpleDnsCrypt with the shipped version of dnscrypt-proxy or compile the latest commit of my fork to get compatibility with dnscrypt-proxy 2.1.0+.

If I'm not wrong, there are some questions that might be similar to mine, especially on: #557

I have noticed these requests quite a long time ago. It puzzles me that no one has yet tried to solve the issue by themselves.

@Shanks17782
Copy link

Thank you for your feedback.

I will try to use Microsoft Visual Studio 2017 to install the new dnscrypt.

However, I will keep an eye out for a possible update or alternative solution you come up with.
The program "Simple DnsCrypt" is a great tool! It would be sad to abandon it.

@Veeno Veeno mentioned this pull request Dec 22, 2021
@Dola-Shuvi
Copy link
Contributor Author

I have created an unofficial 0.7.2 version for now in case anyone stumbles upon this pull request and doesn't want to compile the code themselves. Please read the release notes carefully to prevent avoidable troubleshooting.

@bitbeans bitbeans merged commit 46dcbb7 into bitbeans:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants