Python 3.11 Updates #362
Open
Python 3.11 Updates #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeDaYoshi
reviewed
May 19, 2023
| @@ -235,7 +235,7 @@ def _load_module(self, bot: "IRCBot.Bot", definition: ModuleDefinition, | |||
| definition.filename) | |||
| module = importlib.util.module_from_spec(import_spec) | |||
| sys.modules[import_name] = module | |||
| loader = typing.cast(importlib.abc.Loader, import_spec.loader) | |||
| loader = typing.cast(importlib._abc.Loader, import_spec.loader) | |||
There was a problem hiding this comment.
This didn't work on my setup. The other changes helped it work on Python 3.11; but _abc was undefined, while abc worked.
There was a problem hiding this comment.
@JeDaYoshi -- what is your full release string? I have Python 3.11.3 as the output of python3 --version. Python merged the _abc update for Python a couple years ago -- you'll see the PR in the 22ed4dd commit message.
|
@poVoq have you been able to use this branch on 3.11? |
Sorry I have not tried anything other than the main develop branch, which currently does not work with Python3.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes in Python 3.11 break the bot as written. These two commits should solve it -- I'm testing this branch on my network now.