-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix "pure virtual method called" in kafka_source #34
base: master
Are you sure you want to change the base?
fix "pure virtual method called" in kafka_source #34
Conversation
the "while(!_started) |
The error "pure virtual method called" happens on 146 line. And now I caught it on patched version of kspp. So, it may be that we are calling a In my program I create and destroy the topology in a loop. So constructors and destructors a called pretty frequently. Here is a backtrace (frame 6):
|
wait for kafka_source_base::thread_f() to finish before closing and destroying kafka_source
check exit condition in consuming loop
add specializations
That will do. Now segfault'd gone. Should I create new PR without mistakes or you squash these commits? Or you want to see more deeply why the error happens? |
Sometimes there happens a call to
kafka_source_base::parse()
which is pure virtual.This patch moves initialization of
kafka_source::_thread
fromkafka_source_base
initializer list to a callkafka_source_base::start()
whenkafka_source::thread_f()
is available.