This repository has been archived by the owner on Mar 27, 2022. It is now read-only.
Creates v2.0.0 - New Rendering API #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version adds a more standardized and backwards compatible rendering API (using insertBefore and appendChild for use in older browsers and allowing JSX top-level fragments). The extra render modes are more explicit in location of render, before, prepend, append, and after target element.
|
This PR also includes builds and version bump in the package JSON. Only missing part is github tagging! |
Removed the over-use of the word support!
|
Thanks for this. I will review it on the weekend. One litte note: because of the API changes, I am leaning to a version 2.0.0 for this. |
|
Happy to make that change. I will also alias the old API today, adding deprecation warnings.
… On Oct 14, 2021, at 06:26, Bodo Tasche ***@***.***> wrote:
Thanks for this. I will review it on the weekend. One litte note: because of the API changes, I am leaning to a version 2.0.0 for this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I will also fix these tests. Blindly missed them >_< |
- Fixes tests that I somehow ignored, bad me. - Adds tests for new render modes - Adds tests for rendering fragments - Adds tests for error cases on before/after rendering when given a top level fragment
JaredSartin
changed the title
|
I opted to not alias the old API - as it would be a mess of tangled wires. Happy to do this if we think it would be beneficial. |
- Readme.md reflects 2.0.0 - Adds error cases for before/after when given a fragment - Updates build and package version
|
@JaredSartin sorry for the delay, haven't forgotten this, but everyone in my family is sick with the flu right now, will come back to this when everyone is healthy again. |
|
Not a problem. Take care of you and your family - that’s more important.
… On Oct 18, 2021, at 01:59, Bodo Tasche ***@***.***> wrote:
@JaredSartin sorry for the delay, haven't forgotten this, but everyone in my family is sick with the flu right now, will come back to this when everyone is healthy again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
It's released now 🥳. Thanks for your patience. |
|
Woo! Not a problem, thanks for taking time to validate.
… On Oct 30, 2021, at 13:39, Bodo Tasche ***@***.***> wrote:
It's released now 🥳. Thanks for your patience.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version adds a more standardized and backwards compatible rendering API (using insertBefore and appendChild for use in older browsers and allowing JSX top-level fragments). The extra render modes are more explicit in location of render, before, prepend, append, and after target element.