Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not interrupt action after it finishes #212

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

lostptr
Copy link
Contributor

@lostptr lostptr commented Aug 29, 2023

Description

Whenever a child returns SUCCESS or FAILURE we check if the child is the running_action or the running_child to set them to null. I did the same with the selector node however I could not find a case where selector would interrupt a child incorrectly (only found a case in sequence).

Addressed issues

Closes #211

@lostptr lostptr marked this pull request as ready for review August 29, 2023 02:07
addons/beehave/nodes/composites/sequence.gd Outdated Show resolved Hide resolved
addons/beehave/nodes/composites/sequence.gd Outdated Show resolved Hide resolved
@lostptr lostptr requested a review from bitbrain August 29, 2023 11:54
Copy link
Owner

@bitbrain bitbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and good job.

@bitbrain bitbrain merged commit 78b89ff into bitbrain:godot-4.x Aug 29, 2023
3 checks passed
@lostptr lostptr deleted the bug/unnecessary-interruptions branch August 29, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequence is interrupts action that has already finished.
2 participants