Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #328 - Make the RandomizedComposite node know when to remove weights when children exit #329

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

ksmithdev
Copy link
Contributor

Description

  • Added a test for verifying the issue of weight being reset when a child node of a RandomizedComposite exits and reenters the tree
  • Updated the RandomizedComposite node to check whether the whole node is exiting or not to decide whether to remove weight information when children nodes are exiting

Addressed issues

Screenshots

Navigating away and back resets all weights to 1
image

Now navigating away and back maintains weights
image

Updated the node to keep track of whether the parent and children are all exiting and only remove the child weight if the parent is staying in the tree.
Co-authored-by: miguel <miguel-gonzalez@gmx.de>
Copy link
Owner

@bitbrain bitbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@bitbrain bitbrain merged commit f5e9215 into bitbrain:godot-4.x Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants