Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating existing resources to Pandora breaks Godot #85

Closed
bitbrain opened this issue Aug 25, 2023 · 0 comments · Fixed by #88
Closed

Migrating existing resources to Pandora breaks Godot #85

bitbrain opened this issue Aug 25, 2023 · 0 comments · Fixed by #88
Labels
🐛 bug Something isn't working
Milestone

Comments

@bitbrain
Copy link
Owner

Godot version: 4.0.1
Pandora version: 1.0alpha1

Describe the bug

When trying to migrate a game over to Pandora, one would usually go and change the extends Resource to extends PandoraEntity. However, any existing .tres file that is based on said resource fails to load and it produces a set of errors in Godot. This due to the fact that .tres files are initialised with a default constructor _init() while Pandora resources come with a custom constructor (which breaks things).

To solve this, the _init() on entities could be moved into a lazy init function, but makes it more risky to work with, as a PandoraEntity may be forgotten to be initialised correctly.

@bitbrain bitbrain added the 🐛 bug Something isn't working label Aug 25, 2023
@bitbrain bitbrain added this to the 1.0.0 milestone Aug 25, 2023
@bitbrain bitbrain changed the title Migrating existing resources to Pandora style breaks Godot Migrating existing resources to Pandora breaks Godot Aug 25, 2023
@bitbrain bitbrain pinned this issue Aug 25, 2023
@bitbrain bitbrain unpinned this issue Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant