Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 do not use custom constructor for resource #88

Merged
merged 1 commit into from Aug 26, 2023

Conversation

bitbrain
Copy link
Owner

Closes #85

Description

Migrating existing projects to Pandora can be cumbersome when using .tres files and trying to change the extends Resource to extends PandoraEntity for custom scripts. Suddenly, Godot cannot initialise the pre-existing .tres files and it breaks everything.

This PR ensures that PandoraEntity can still be initialised by Godot if it is based on a .tres file during migration.

@bitbrain bitbrain merged commit a1fe589 into godot-4.x Aug 26, 2023
3 checks passed
@bitbrain bitbrain deleted the empty-resource-constructor branch August 26, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating existing resources to Pandora breaks Godot
1 participant