💽 Import data functionality #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! We may need a few more unit tests in api_test.gd for:
You could dynamically create data.pandora files in there by using the context id and then importing them into another file. Make sure to clean up all the data afterwards. Similar logic exists already in there. |
bitbrain
reviewed
Sep 7, 2023
bitbrain
reviewed
Sep 7, 2023
bitbrain
reviewed
Sep 7, 2023
bitbrain
reviewed
Sep 7, 2023
bitbrain
reviewed
Sep 7, 2023
bitbrain
reviewed
Sep 15, 2023
bitbrain
reviewed
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the possibility to import and merge .pandora files into the existing data set. As suggested by @bitbrain in the issue #17, repeated data will be skipped by default.
Addressed issues
Screenshots