♻️ rework property type lookup #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitbrain
force-pushed
the
supported-type-lookup
branch
from
e570041
to
cfb34ad
Compare
bitbrain
commented
Aug 31, 2023
| new_property.load_data(property.save_data()) | ||
| assert_that(new_property.get_default_value()).is_null() | ||
| assert_that(new_property.get_default_value()).is_equal("") |
There was a problem hiding this comment.
These tests now change as it is impossible to create a PandoraProperty that has a valid type but an invalid default value.
bitbrain
commented
Aug 31, 2023
|
|
||
|
|
||
|
|
||
| func get_default_settings() -> Dictionary: |
There was a problem hiding this comment.
Settings are now comping from the type directly, rather than from some random UI component.
bitbrain
commented
Aug 31, 2023
| class_name PandoraPropertyType extends RefCounted | ||
|
|
||
|
|
||
| class UndefinedType extends PandoraPropertyType: |
There was a problem hiding this comment.
This type is useful to avoid null checks but have instead an undefined type.
bitbrain
force-pushed
the
supported-type-lookup
branch
from
cfb34ad
to
0285a06
Compare
bitbrain
commented
Aug 31, 2023
| if name == "": | ||
| return UndefinedType.new() | ||
| var ScriptType = load("res://addons/pandora/model/types/" + name + ".gd") | ||
| if ScriptType != null and ScriptType.has_source_code(): |
There was a problem hiding this comment.
This explicit check is required since Godot 4.0.x and 4.1.x have different behavior:
- Godot 4.0.x:
load()returnsGDScripteven if it failed to load - Godot 4.1.x:
load()returnsnull
eth0net
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for:
Description
Complete overhaul of the type system of Pandora by introducing the
PandoraPropertyTypeclass. This allows us to make it easier to specify new types, e.g. by adding a new file tores://addons/pandora/model/types/new-type.gdwhich then internally specifies everything Pandora needs to know, including serialization, property settings and validation!Highlights
PandoraPropertyand move it over intoPandoraPropertyType- instead, it now acts as a "stupid" containerPandoraPropertynow gets its default value from the type, rather than having to pass it in manuallyFunctionally, this pull request should not change anything critically.