fix: restore threadDoubleAccordion sticky effect

[TopETH]

Close #117

Summary by CodeRabbit

• New Features
  • Added an optional isSticky property to the AccordionTrigger component to enhance UI customization.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
masterbots	✅ Ready (Inspect)	Visit Preview	💬 1 unresolved	May 3, 2024 0:55am

[coderabbitai]

Walkthrough

The recent updates involve enhancements to the AccordionTrigger component by adding an isSticky prop to manage sticky behavior. This modification spans across two files, aiming to restore sticky functionality to the ThreadDoubleAccordion component as per project requirements.

Changes

File Path	Change Summary
.../shared/thread-list-accordion.tsx	Added isSticky prop to AccordionTrigger.
.../ui/accordion.tsx	Extended AccordionTriggerProps to include isSticky? boolean; updated component to use new props interface.

Assessment against linked issues

Objective	Addressed	Explanation
Restore ThreadDoubleAccordion sticky effect (#117)	✅

Poem

🐰 Oh hop and skip, the code does flip,
A sticky prop, in place it drops.
🎈 With each key stroke, new life evokes,
Accordion sings, as sticky clings.
🌟 To threads we bind, in code we find,
A rabbit's joy, in deploy's alloy.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 00f952c and 69e2f6e.

Files selected for processing (2)

• apps/masterbots.ai/components/shared/thread-list-accordion.tsx (1 hunks)
• apps/masterbots.ai/components/ui/accordion.tsx (2 hunks)

Additional comments not posted (1)

apps/masterbots.ai/components/ui/accordion.tsx (1)

29-37: Review the CSS selector for sticky behavior.

The CSS selector [&[data-state=open]]:sticky [&[data-state=open]]:top-0 z-[1] used in the AccordionTrigger component might not behave as expected across all browsers. Verify that this selector achieves the desired sticky effect in all target browsers.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Out of diff range and nitpick comments (2)

apps/masterbots.ai/components/shared/thread-list-accordion.tsx (1)

38-40: Ensure isSticky prop is properly documented.

Consider adding a comment or documentation for the isSticky prop to explain its purpose and usage within the AccordionTrigger component. This will enhance code readability and maintainability.

apps/masterbots.ai/components/ui/accordion.tsx (1)

8-11: Properly document the isSticky property in the AccordionTriggerProps interface.

Add a comment above the isSticky property in the AccordionTriggerProps interface to explain its purpose and how it affects the behavior of the AccordionTrigger component. This will help other developers understand the context and usage of this property.

[github-actions]

⚡️ Lighthouse report

Page: https://masterbots-cszhx0eqv-bitcash.vercel.app/
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1714672888755-33674.report.html

Category	Score
🔴 Performance	40
🟢 Accessibility	96
🟠 Best practices	78
🟠 SEO	85
🔴 PWA	38

Page: https://masterbots-cszhx0eqv-bitcash.vercel.app/b/moneybot
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1714672889384-35793.report.html

Category	Score
🟠 Performance	53
🟢 Accessibility	95
🟠 Best practices	78
🟠 SEO	85
🔴 PWA	38

Page: https://masterbots-cszhx0eqv-bitcash.vercel.app/u/slug-1
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1714672889770-5577.report.html

Category	Score
🟠 Performance	60
🟢 Accessibility	94
🟠 Best practices	78
🟠 SEO	83
🔴 PWA	38

Page: https://masterbots-cszhx0eqv-bitcash.vercel.app/p
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1714672890100-16927.report.html

Category	Score
🟠 Performance	57
🟢 Accessibility	92
🟠 Best practices	78
🟠 SEO	76
🔴 PWA	38

Page: https://masterbots-cszhx0eqv-bitcash.vercel.app/health
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1714672890366-95681.report.html

Category	Score
🟠 Performance	57
🟠 Accessibility	59
🟠 Best practices	74
🔴 SEO	42
🔴 PWA	13

Page: https://masterbots-cszhx0eqv-bitcash.vercel.app/health/a8103808-14a3-48ed-aa5a-9e490cfdcf0e
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1714672890634-60697.report.html

Category	Score
🟠 Performance	53
🟠 Accessibility	59
🟠 Best practices	74
🔴 SEO	42
🔴 PWA	13

[AndlerRL]

LGTM! Thanks for taking care the sticky detail. I nothice though a UI detail with the left padding when the accordion is open. That can be addressed on another ticket. Mergin 👍

[AndlerRL]

Review and Fix Alpha UI/UX Regressions