Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed decryption not working in the browser for messages > 15 #64

Merged
merged 7 commits into from
Aug 5, 2020
Merged

fixed decryption not working in the browser for messages > 15 #64

merged 7 commits into from
Aug 5, 2020

Conversation

YZhenY
Copy link
Contributor

@YZhenY YZhenY commented Jun 25, 2020

No description provided.

@YZhenY YZhenY changed the title decryption not working in the browser for messages > 15 fixed decryption not working in the browser for messages > 15 Jun 25, 2020
@YZhenY
Copy link
Contributor Author

YZhenY commented Jun 25, 2020 •
edited

ah did not realize #47

can we merge one or the other please @JBaczuk

@ibudisteanu
Copy link

@YZhenY great stuff. I believe your update is solving this issue created by me #67 isn't it ?

JBaczuk
JBaczuk reviewed Jul 24, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
JBaczuk
JBaczuk suggested changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@JBaczuk JBaczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, sorry for the late response. I noticed a few things that would need to be fixed before merging. Could you take a look?

package.json Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
test.js Show resolved Hide resolved
@ibudisteanu ibudisteanu mentioned this pull request Jul 24, 2020
Closed
@YZhenY
Copy link
Contributor Author

YZhenY commented Jul 28, 2020 •
edited

done! @JBaczuk @ibudisteanu

@YZhenY YZhenY requested a review from JBaczuk August 5, 2020 06:00
@JBaczuk JBaczuk merged commit bd98514 into bitchan:master Aug 5, 2020
@JBaczuk
Copy link
Contributor

JBaczuk commented Aug 5, 2020

Thanks @YZhenY !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibudisteanu ibudisteanu ibudisteanu left review comments

@JBaczuk JBaczuk Awaiting requested review from JBaczuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YZhenY @ibudisteanu @JBaczuk