Skip to content

Commit

Permalink
n28690: Update for newest patch set
Browse files Browse the repository at this point in the history
  • Loading branch information
TheCharlatan committed Nov 29, 2023
1 parent cfc45f8 commit 832fe32
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions _posts/2023-12-06-#28690.md
Expand Up @@ -43,11 +43,9 @@ commit: de6d79847537cd7d0dfc3e2dd7a57b39b4281b5a

7. Why does the `libbitcoinkernel_la_SOURCES` source file list specifically include `$(libbitcoin_util_a_SOURCES)` and `$(libbitcoin_consensus_a_SOURCES)` but `libbitcoin_kernel_a_SOURCES` doesn't seem to?

8. [Commit 515c995](https://github.com/bitcoin-core-review-club/bitcoin/commit/515c9952829256f4c75c82d90f9ea4994b03baee) mentions: "Moving util/message.cpp to the common library also breaks an undocumented dependency of the util library on the consensus library's CPubKey::RecoverCompact symbol.". What was this dependency?
8. [Commit 41a80de](https://github.com/bitcoin-core-review-club/bitcoin/commit/41a80de022691c9f5edd5cf715974fedadbffc12) mentions: "Moving util/message.cpp to the common library also breaks an undocumented dependency of the util library on the consensus library's CPubKey::RecoverCompact symbol.". What was this dependency?

9. [Commit 515c995](https://github.com/bitcoin-core-review-club/bitcoin/commit/515c9952829256f4c75c82d90f9ea4994b03baee) introduces a `shift-base:common/bip32.cpp` suppression in `test/sanitizer_suppressions/ubsan`. Why do we need this?

10. [Commit de6d798](https://github.com/bitcoin-core-review-club/bitcoin/commit/de6d79847537cd7d0dfc3e2dd7a57b39b4281b5a) de-duplicates the source file list. Are there any changes to the source file list used for `libbitcoinkernel`?
9. [Commit 5a6a0b1](https://github.com/bitcoin-core-review-club/bitcoin/commit/5a6a0b1693cf739a5e6cc1161160a1d621d215f9) de-duplicates the source file list. Are there any changes to the source file list used for `libbitcoinkernel`?

<!-- TODO: After a meeting, uncomment and add meeting log between the irc tags
## Meeting Log
Expand Down

0 comments on commit 832fe32

Please sign in to comment.