Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 64bit interpreter review #752

Merged

Conversation

Christewart
Copy link
Contributor

@Christewart Christewart commented Mar 12, 2024

Code review for #29221 works and how its different that what we have in bitcoin core's supported arithmetic.

@glozow
Copy link
Contributor

glozow commented Mar 13, 2024

Fantastic, thank you @Christewart :)

Copy link
Contributor

@glozow glozow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These notes are super helpful 👍

_posts/2024-03-20-#29221.md Outdated Show resolved Hide resolved
_posts/2024-03-20-#29221.md Outdated Show resolved Hide resolved
@Christewart Christewart marked this pull request as ready for review March 17, 2024 12:09
@Christewart Christewart requested a review from glozow March 17, 2024 12:32
Copy link
Contributor

@glozow glozow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great notes 🚀! I just have a few nits suggested below. If you prefer, I can push up a minor commit to fix these and then merge.

_posts/2024-03-20-#29221.md Outdated Show resolved Hide resolved
_posts/2024-03-20-#29221.md Outdated Show resolved Hide resolved
_posts/2024-03-20-#29221.md Outdated Show resolved Hide resolved
_posts/2024-03-20-#29221.md Outdated Show resolved Hide resolved
_posts/2024-03-20-#29221.md Outdated Show resolved Hide resolved
Christewart and others added 5 commits March 18, 2024 07:25
Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>
Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>
Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>
Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>
Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>
@Christewart Christewart requested a review from glozow March 18, 2024 12:26
@glozow glozow merged commit 34a408c into bitcoin-core-review-club:master Mar 18, 2024
4 checks passed
@glozow
Copy link
Contributor

glozow commented Mar 18, 2024

Really looking forward to this! :) thanks @Christewart

glozow added a commit to glozow/website that referenced this pull request Mar 20, 2024
…-03-12-64bit-review

Add 64bit interpreter review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants