New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 64bit interpreter review #752
Add 64bit interpreter review #752
Conversation
Fantastic, thank you @Christewart :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These notes are super helpful 👍
Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>
Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great notes 🚀! I just have a few nits suggested below. If you prefer, I can push up a minor commit to fix these and then merge.
Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>
Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>
Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>
Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>
Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>
Really looking forward to this! :) thanks @Christewart |
…-03-12-64bit-review Add 64bit interpreter review
Code review for #29221 works and how its different that what we have in bitcoin core's supported arithmetic.