Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Providing device support information via CLI #273

Open
NicolasDorier opened this issue Oct 28, 2019 · 2 comments · May be fixed by #295
Open

[Feature] Providing device support information via CLI #273

NicolasDorier opened this issue Oct 28, 2019 · 2 comments · May be fixed by #295
Labels
feature request

Comments

@NicolasDorier
Copy link

NicolasDorier commented Oct 28, 2019 •
edited
Loading

The information on https://github.com/bitcoin-core/HWI#device-support should be hard coded and able to be consumed via the HWI CLI so we can properly activate/deactivate feature in the GUI based on the detected device.

Because right now, I am scrapping github README page to have that in my middleware.
@achow101
Copy link
Member

What kind of things are you looking for? Like what kind of txs can be signed? Some things can be "retrieved" by just running the command and checking the error, e.g. signmessage, getxpub.

Maybe we could add a deviceinfo command that returns device info including what things it supports.

@NicolasDorier
Copy link
Author

Maybe we could add a deviceinfo command that returns device info including what things it supports.

Yes this is what I want.

What kind of things are you looking for? Like what kind of txs can be signed? Some things can be "retrieved" by just running the command and checking the error, e.g. signmessage, getxpub.

I know, but this is a poor UX. This mean that the end user will try it, and see his action fail. Instead I wish to preemptively disable the action in the UI saying "Your hardware wallet does not support this action".

@achow101 achow101 linked a pull request Jan 3, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

List features achow101/hardware-wallet-interface
2 participants
@NicolasDorier @achow101