Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taproot support #501

Closed
Sjors opened this issue Apr 1, 2021 · 11 comments
Closed

Taproot support #501

Sjors opened this issue Apr 1, 2021 · 11 comments

Comments

@Sjors
Copy link
Member

Sjors commented Apr 1, 2021

Afaik none of the hardware wallets we support currently has even a draft implementation of Taproot. But we can update this issue when that happens.

@yeru83
Copy link

yeru83 commented Jul 2, 2021

Not sure here, but as of July, there Appears to be some progress in the BitBox02, as of April
https://github.com/bitcoin-core/HWI/search?q=taproot

edit:typo

@prusnak
Copy link
Collaborator

prusnak commented Jul 2, 2021

Tracking issue for Trezor Taproot Support: trezor/trezor-firmware#1656

@craigraw
Copy link

Ledger appears to have Taproot support now: https://blog.ledger.com/taproot-support/

Also, it appears HWI does not support the tr script expression for displaying an address. HWI currently returns tr is not a valid descriptor function when a BIP386 Taproot output descriptor is used for the --desc argument.

@Sjors
Copy link
Member Author

Sjors commented Nov 17, 2021

Great to hear that Ledger supports Taproot receive addresses.

@achow101
Copy link
Member

Ledger appears to have Taproot support now: https://blog.ledger.com/taproot-support/

Interesting. I wasn't able to find any technical docs for how to use Taproot on ledger devices.

Also, it appears HWI does not support the tr script expression for displaying an address. HWI currently returns tr is not a valid descriptor function when a BIP386 Taproot output descriptor is used for the --desc argument.

This is currently in progress.


Trezor recently merged Taproot support for the Trezor T: trezor/trezor-firmware#1891. The initial support PR will likely only include Trezor T support as it is the easiest one for me to find documentation for and test.

@Sjors
Copy link
Member Author

Sjors commented Nov 17, 2021

cc @btchip @TamtamHero

@prusnak
Copy link
Collaborator

prusnak commented Nov 18, 2021

Trezor recently merged Taproot support for the Trezor T: trezor/trezor-firmware#1891. The initial support PR will likely only include Trezor T support as it is the easiest one for me to find documentation for and test.

Taproot for Trezor Model One is in this PR trezor/trezor-firmware#1917 (soon to be merged). It should work the same way as on Trezor Model T, so if your HWI changes work with Trezor Model T, they should also work with the Trezor Model One.

Both Trezor Model T and Trezor Model One firmwares with Taproot functionality will be released in the middle of December.

@achow101 achow101 pinned this issue Nov 25, 2021
@gruve-p
Copy link
Contributor

gruve-p commented Nov 29, 2021

Tracking issue for Trezor Taproot Support: trezor/trezor-firmware#1656

That one is closed and seperated into subtasks:
trezor/trezor-firmware#1943
trezor/trezor-firmware#1944
trezor/trezor-firmware#1946

@gruve-p
Copy link
Contributor

gruve-p commented Nov 29, 2021

Interesting. I wasn't able to find any technical docs for how to use Taproot on ledger devices.

https://blog.ledger.com/bitcoin-2/

cc @bigspider

@prusnak
Copy link
Collaborator

prusnak commented Nov 29, 2021

That one is closed and seperated into subtasks:
trezor/trezor-firmware#1943
trezor/trezor-firmware#1944
trezor/trezor-firmware#1946

That is not entirely correct. Taproot for singlesig has been implemented in full for both Trezor Model One and Trezor Model T. The tasks you linked were created for remaining stuff not related to singlesig (such as message signing, ownership proofs and multisig).

@Sjors
Copy link
Member Author

Sjors commented Sep 6, 2022

Closing this, since at least some wallets now have basic Taproot keypath support.

Shameless plug for bitcoin/bitcoin#23578 which adds Bitcoin Core support for importing keypath descriptors from an external signer.

@Sjors Sjors closed this as completed Sep 6, 2022
@achow101 achow101 unpinned this issue Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants