Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --emulators option to explicitly choose to detect emulators in enumeration and device auto detection #729

Merged
merged 2 commits into from Apr 1, 2024

Conversation

achow101
Copy link
Member

@achow101 achow101 commented Mar 26, 2024

This changes the default behavior to ignore emulators unless specified with --emulators. Since this is a backwards incompatible change, the major version number is bumped to 3.

Closes #653

@achow101 achow101 force-pushed the no-emulators branch 4 times, most recently from 901d8f5 to 6ab70d3 Compare March 29, 2024 16:36
@achow101 achow101 changed the title Add enumerate --no-emulators option to skip enumerating emulators Add --emulators option to explicitly choose to detect emulators in enumeration and device auto detection Mar 29, 2024
@achow101 achow101 force-pushed the no-emulators branch 3 times, most recently from b19b477 to 9f4ee3e Compare March 30, 2024 01:23
@achow101
Copy link
Member Author

cc @prusnak @craigraw

@craigraw
Copy link

craigraw commented Apr 1, 2024

LGTM.

I tested:

  • Singlesig and multisig signing with a couple of hwws
  • With --emulators and without while separately opening a server on localhost:9999. With --emulators HWI hangs on enumeration, without it does not.

@achow101 achow101 merged commit b5786ad into bitcoin-core:master Apr 1, 2024
255 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't enumerate emulators unless --emulator flag is provided
2 participants